Repository navigation
Implement GDPatch modloader installers - #2303
Open
ethangreen-dev wants to merge 3 commits into
Open
ethangreen-dev wants to merge 3 commits into
ethangreen-dev wants to merge 3 commits into
Conversation
ebkr
requested changes
Oct 6, 2026
ethangreen-dev
commented
Oct 6, 2026
NotNite
reviewed
Oct 6, 2026
|
|
||
| const fs = FsProvider.instance; | ||
|
|
||
| const windowsLoaderSrc = path.join(packagePath, "gdpatch_loader.dll"); |
Contributor
There was a problem hiding this comment.
It's probably wise of us to rename this to winmm.dll in the package itself to make extracting it manually user-proof; should this filename be updated in that case?
Owner
There was a problem hiding this comment.
@NotNite Probably? It would make sense for it to be easy to manually install the package.
Contributor
There was a problem hiding this comment.
We haven't packaged GDPatch just yet (we wanted preliminary mod manager support first), so let's assume the DLL will be named winmm.dll in the package and fix the path here.
Renaming files to .old leaves a folder without gdpatch_mod.toml, which GDPatch logs as a broken mod. The marker was agreed with the GDPatch maintainers.
ethangreen-dev
force-pushed
the
gdpatch
branch
from
October 7, 2026 20:51
3f112b5 to
f27a95c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements the modloader and mod installers for the GDPatch modloader.
https://github.com/GDPatch/GDPatch